search

xceedsoftware / wpftoolkit

All the controls missing in WPF. Over 1 million downloads.
Other
3.87k stars 873 forks source link

Xceed.Wpf.AvalonDock.resources.dll has wrong culture #1642

Open JosbertLonnee opened 3 years ago

JosbertLonnee commented 3 years ago

We found a bug in the Extended.Wpf.Toolkit version 3.8.0:

The Xceed.Wpf.AvalonDock.resources.dll ending up in the language specific "cs-CZ" directory has, just like the one in the "de" directory, culture=de (German).

How to issue a bug report for this apart from submitting it here?

This bug costed my team a whole day of work by the way.

Thanks in advance.

XceedBoucherS commented 3 years ago

Hi, Thank you for reporting this. Can you explain where is the problem exactly ? I understand it's in Xceed.Wpf.AvalonDock\Properties\Resources.cs-CZ.resx, but was is wrong exactly ? Which line is wrong ?

Have you tried the latest version to see if the problem persist ? Are you using the free version from GitHub or the commercial version from Xceed ? Thank you.

JosbertLonnee commented 3 years ago

Hi,

This is what I see when I open that DLL with ILSpy:

[cid:image011.jpg@01D70055.62F40B60]

Please notice that the DLL, that after a build ends up in directory "bin\cs-CZ", has: Culture=de I do not know where that culture is set. I checked out https://github.com/xceedsoftware/wpftoolkit.git , but I did not see this setting in the Resources.cs-CZ.resx

Josbert Lonnee Software Engineer

[cid:image012.png@01D70055.62F40B60] Malvern Panalytical B.V. Lelyweg 1 (7602 EA) PO Box 13 7600 AA Almelo The Netherlands

josbert.lonnee@malvernpanalytical.commailto://josbert.lonnee@malvernpanalytical.com www.malvernpanalytical.comhttp://www.malvernpanalytical.com

[LinkedIn - Malvern Panalytical]https://nl.linkedin.com/company/malvernpanalytical/ [Twitter - Malvern Panalytical] https://twitter.com/newsfrom_MP/ [Facebook - Malvern Panalytical] https://www.facebook.com/MalvernPanalytical/ [YouTube - Malvern Panalytical] https://www.youtube.com/MalvernPanalytical/ [Blog - Malvern Panalytical] https://www.materials-talks.com/

CoC Registration No. 06069492, Enschede, The Netherlands This email and any files transmitted with it are confidential and maybe legally privileged. Such message is intended solely for the use of the individual or entity to whom they are addressed. Please notify the originator of the message if you are not the intended recipient and destroy all copies of the message. Please note that any use, dissemination, or reproduction is strictly prohibited and may be unlawful.

The way we want to do business: Our Code of Business Ethicshttps://www.malvernpanalytical.com/en/about-us/about-malvern-panalytical/corporate-citizenship/ethics/

From: XceedBoucherS notifications@github.com Sent: Wednesday, February 10, 2021 21:12 To: xceedsoftware/wpftoolkit wpftoolkit@noreply.github.com Cc: Josbert Lonnee josbert.lonnee@panalytical.com; Author author@noreply.github.com Subject: Re: [xceedsoftware/wpftoolkit] Xceed.Wpf.AvalonDock.resources.dll has wrong culture (#1642)

Hi, Thank you for reporting this. Can you explain where is the problem exactly ? I understand it's in Xceed.Wpf.AvalonDock\Properties\Resources.cs-CZ.resx, but was is wrong exactly ? Which line is wrong ?

Have you tried the latest version to see if the problem persist ? Are you using the free version from GitHub or the commercial version from Xceed ? Thank you.

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxceedsoftware%2Fwpftoolkit%2Fissues%2F1642%23issuecomment-776992790&data=04%7C01%7Cjosbert.lonnee%40panalytical.com%7C61134819a3284a8a3c3208d8ce001458%7C071061f3d56946889edeb63a6a7f1ecc%7C0%7C0%7C637485847042792986%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=NoQH478TsJ5BpFEIb0Hfo0LkF7iBANrU%2FBd9pmZW5pY%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASZESRHDVEKIIVSQB3VL5RDS6LR7XANCNFSM4XKV5OOQ&data=04%7C01%7Cjosbert.lonnee%40panalytical.com%7C61134819a3284a8a3c3208d8ce001458%7C071061f3d56946889edeb63a6a7f1ecc%7C0%7C0%7C637485847042792986%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=TZp%2BOlbio0NLpfHJu2C94CA9NRB06o%2BXkR%2FaRMdNWCQ%3D&reserved=0.

JosbertLonnee commented 3 years ago

Hi,

Only now I see that the DLL that ends up, after a build, in the "cs-CZ" subfolder is identical to the one that ends up in the "de" folder. I think the error is somewhere in the build process.

I hope this helps.

Josbert Lonnee Software Engineer

[cid:image002.png@01D70058.308F03C0] Malvern Panalytical B.V. Lelyweg 1 (7602 EA) PO Box 13 7600 AA Almelo The Netherlands

josbert.lonnee@malvernpanalytical.commailto://josbert.lonnee@malvernpanalytical.com www.malvernpanalytical.comhttp://www.malvernpanalytical.com

[LinkedIn - Malvern Panalytical]https://nl.linkedin.com/company/malvernpanalytical/ [Twitter - Malvern Panalytical] https://twitter.com/newsfrom_MP/ [Facebook - Malvern Panalytical] https://www.facebook.com/MalvernPanalytical/ [YouTube - Malvern Panalytical] https://www.youtube.com/MalvernPanalytical/ [Blog - Malvern Panalytical] https://www.materials-talks.com/

CoC Registration No. 06069492, Enschede, The Netherlands This email and any files transmitted with it are confidential and maybe legally privileged. Such message is intended solely for the use of the individual or entity to whom they are addressed. Please notify the originator of the message if you are not the intended recipient and destroy all copies of the message. Please note that any use, dissemination, or reproduction is strictly prohibited and may be unlawful.

The way we want to do business: Our Code of Business Ethicshttps://www.malvernpanalytical.com/en/about-us/about-malvern-panalytical/corporate-citizenship/ethics/

From: XceedBoucherS notifications@github.com Sent: Wednesday, February 10, 2021 21:12 To: xceedsoftware/wpftoolkit wpftoolkit@noreply.github.com Cc: Josbert Lonnee josbert.lonnee@panalytical.com; Author author@noreply.github.com Subject: Re: [xceedsoftware/wpftoolkit] Xceed.Wpf.AvalonDock.resources.dll has wrong culture (#1642)

Hi, Thank you for reporting this. Can you explain where is the problem exactly ? I understand it's in Xceed.Wpf.AvalonDock\Properties\Resources.cs-CZ.resx, but was is wrong exactly ? Which line is wrong ?

Have you tried the latest version to see if the problem persist ? Are you using the free version from GitHub or the commercial version from Xceed ? Thank you.

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxceedsoftware%2Fwpftoolkit%2Fissues%2F1642%23issuecomment-776992790&data=04%7C01%7Cjosbert.lonnee%40panalytical.com%7C61134819a3284a8a3c3208d8ce001458%7C071061f3d56946889edeb63a6a7f1ecc%7C0%7C0%7C637485847042792986%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=NoQH478TsJ5BpFEIb0Hfo0LkF7iBANrU%2FBd9pmZW5pY%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASZESRHDVEKIIVSQB3VL5RDS6LR7XANCNFSM4XKV5OOQ&data=04%7C01%7Cjosbert.lonnee%40panalytical.com%7C61134819a3284a8a3c3208d8ce001458%7C071061f3d56946889edeb63a6a7f1ecc%7C0%7C0%7C637485847042792986%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=TZp%2BOlbio0NLpfHJu2C94CA9NRB06o%2BXkR%2FaRMdNWCQ%3D&reserved=0.

XceedBoucherS commented 3 years ago

Hi JosbertLonnee, Which version of the Toolkit are you using ? Is it the latest one ? Did you get it from GitHub or NuGet ? I can't see the image you attached showing the error. Based on the resource.resx from AvalonDock Properties folder, the strings are not the same in "Cs-CZ" compared to "de". What makes you say the dlls are identical ? Thank you.

JosbertLonnee commented 3 years ago

Hello,

We use version 3.8.0 of the Extended.Wpf.Toolkit, which is included in our project via a NuGet package. We can see the DLL's are identical by inspecting them with the ILSpy decompiler for .NET. It shows the DLL ending-up under the cs-cz folder has Culture=de and contains German content.

I hope this helps.

Josbert Lonnee Software Engineer

[cid:image008.png@01D70B9E.9ABDB060] Malvern Panalytical B.V. Lelyweg 1 (7602 EA) PO Box 13 7600 AA Almelo The Netherlands

josbert.lonnee@malvernpanalytical.commailto://josbert.lonnee@malvernpanalytical.com www.malvernpanalytical.comhttp://www.malvernpanalytical.com

[LinkedIn - Malvern Panalytical]https://nl.linkedin.com/company/malvernpanalytical/ [Twitter - Malvern Panalytical] https://twitter.com/newsfrom_MP/ [Facebook - Malvern Panalytical] https://www.facebook.com/MalvernPanalytical/ [YouTube - Malvern Panalytical] https://www.youtube.com/MalvernPanalytical/ [Blog - Malvern Panalytical] https://www.materials-talks.com/

CoC Registration No. 06069492, Enschede, The Netherlands This email and any files transmitted with it are confidential and maybe legally privileged. Such message is intended solely for the use of the individual or entity to whom they are addressed. Please notify the originator of the message if you are not the intended recipient and destroy all copies of the message. Please note that any use, dissemination, or reproduction is strictly prohibited and may be unlawful.

The way we want to do business: Our Code of Business Ethicshttps://www.malvernpanalytical.com/en/about-us/about-malvern-panalytical/corporate-citizenship/ethics/

From: XceedBoucherS notifications@github.com Sent: Monday, February 22, 2021 15:16 To: xceedsoftware/wpftoolkit wpftoolkit@noreply.github.com Cc: Josbert Lonnee josbert.lonnee@panalytical.com; Author author@noreply.github.com Subject: Re: [xceedsoftware/wpftoolkit] Xceed.Wpf.AvalonDock.resources.dll has wrong culture (#1642)

Hi JosbertLonnee, Which version of the Toolkit are you using ? Is it the latest one ? Did you get it from GitHub or NuGet ? I can't see the image you attached showing the error. Based on the resource.resx from AvalonDock Properties folder, the strings are not the same in "Cs-CZ" compared to "de". What makes you say the dlls are identical ? Thank you.

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fxceedsoftware%2Fwpftoolkit%2Fissues%2F1642%23issuecomment-783405151&data=04%7C01%7Cjosbert.lonnee%40panalytical.com%7C4395a4a8d00d4b2dcfca08d8d73c4fd0%7C071061f3d56946889edeb63a6a7f1ecc%7C0%7C0%7C637496001336190143%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=nS9PkORBIAEkni36czG3tHGjW2RbeDBqSJINqCHPMbM%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASZESRGIYVHILV3COTFP3PDTAJRIFANCNFSM4XKV5OOQ&data=04%7C01%7Cjosbert.lonnee%40panalytical.com%7C4395a4a8d00d4b2dcfca08d8d73c4fd0%7C071061f3d56946889edeb63a6a7f1ecc%7C0%7C0%7C637496001336190143%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=GLQSXxM8ol9WVjo4JhVIgP5CqylW1BGgBtPQ7EmbIsM%3D&reserved=0.

XceedBoucherS commented 3 years ago

Hi, After trying with "ILSpy" and "JetBrains dot Peek", I can't see a "de" culture nor German text in this Czech resource file. I copied the texts in "Google Translate" and the texts are all "Czech".

When looking for Xceed Toolkit on NuGet, I found: v3.8.1 v3.8.2 v4.0.0 v4.0.1 v4.0.2 I suggest you try with v3.8.2 and v4.0.2 which are the more stable versions. v4.0.2 is the latest version.

Thank you.