xcore / sc_ethernet

10/100 MII Ethernet MAC for XMOS microcontrollers
http://xcore.github.com/sc_ethernet/index.html
Other
37 stars 29 forks source link

Function call parameter mismatch in two port MAC #62

Open ahogen opened 7 years ago

ahogen commented 7 years ago

How does this function call...

// In file: src/full/ethernet_server.xc    line #65
ethernet_tx_server(mac_address, tx, 2, num_tx, smi1, null);

... match the interface (below)...

// In file: src/full/ethernet_tx_server.xc    line #112
#pragma unsafe arrays
    void ethernet_tx_server(
#if ETHERNET_TX_HP_QUEUE
                        mii_mempool_t tx_mem_hp[],
#endif
                        mii_mempool_t tx_mem_lp[],
                        int num_q,
                        mii_ts_queue_t ts_queue[],
                        const char mac_addr[],
                        chanend tx[],
                        int num_tx,
                        smi_interface_t &?smi1,
                        smi_interface_t &?smi2)

The MAC address and queuing parameter positions are completely mismatched. How was this ever supposed to work?