search

xela144 / CANaconda

CANaconda project: CAN message viewer
GNU General Public License v3.0
10 stars 0 forks source link

Command line options are out of date #45

Closed Susurrus closed 9 years ago

Susurrus commented 10 years ago

Maybe it's just the --help docs, but for example --messages should probably --metadata, since that's what the files are called now. Additionally, --nogui takes a PORT argument, which seems redundant with the -p option.

xela144 commented 9 years ago

104f318dcbc9b7855ff775fd5f91fc57c008dd39

xela144 commented 9 years ago

--nogui has a positional argument, port, which is necessary since there is no other way to get the port.

Without --nogui, we launch the GUI. --port is a shortcut for launching the program with a port pre-selected.

I can re-order this logic to make it more clear.

Susurrus commented 9 years ago

Make the --nogui option just a boolean flag and leave the port argument as it is. It should be required when nogui is specified otherwise optional. This is a nicer design.

xela144 commented 9 years ago

104f318dcbc9b7855ff775fd5f91fc57c008dd39 and afd22327adde3689bf5904511ba9f2867e8e7894