search

xela144 / CANaconda

CANaconda project: CAN message viewer
GNU General Public License v3.0
10 stars 0 forks source link

Loading a second metadata file does weird things #70

Closed Susurrus closed 9 years ago

Susurrus commented 9 years ago

I've had problems with this, confirm it works properly. Especially what should/does happen if the 2nd metadata file parses incorrectly. Those edge cases need to be handled.

xela144 commented 9 years ago

Can you elaborate? I just tried and it works.

The only bug is that the second time you load the metadata, the dialog window goes to the background (on ubuntu). This is because the dialog window code is a one-liner. Will fix this. But what other 'weird things' does it do?

Susurrus commented 9 years ago

I think what happened is that I loaded a second metadata file which failed to parse. So in that case the application was left in a weird state because it didn't fully load the second file.

Susurrus commented 9 years ago

This is definitely possible for user-created XML files as well, so this should be fixed by 1.0

xela144 commented 9 years ago

Alright, I'll try to replicate this.

xela144 commented 9 years ago

Tried this: Load 'AllMessage.xml' and begin streaming. Load 'badMetdata.xml'. The old XML file is still visible in the Metadata tab, but the program cannot parse any messages.

So we need to find a way to clear the Metadata tab when a bad file is loaded, or not load the bad file and just keep the old one.

xela144 commented 9 years ago

b7b2431a57b8c99f9a501a1b43a1ed1eb9d2ad11