search

xelerance / Openswan

Openswan
Other
852 stars 214 forks source link

lib/libopenswan/constants.c: fix build on uclibc-ng #453

Closed ffontaine closed 3 years ago

ffontaine commented 3 years ago

Use ns_t_tsig - 1 instead of ns_t_tkey which is not defined in uclibc-ng resulting in the following build failure:

openswan-2.6.52.2/lib/libopenswan/constants.c:1432:31: error: ‘ns_t_tkey’ undeclared here (not in a function)
 enum_names rr_qtype_names = { ns_t_tkey, ns_t_any
                               ^

Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

ffontaine commented 3 years ago

I updated the PR as requested

shussain commented 3 years ago

@ffontaine thank you for the PR.

While we appreciate the commit, it is for a workaround for a specific libc that we are puling into our repo. We feel the fix should be applied to the uclibc-ng instead.

ffontaine commented 3 years ago

OK, then I'll disable openswan with uclibc-ng on buildroot as we can't expect that every uclibc-ng toolchains on the field will get patched any time soon.

letoams commented 3 years ago

the real fix is to rip out that ancient bind4 code anyway. It's hasn't been used since freeswan days in 2003

libreswan is a dropin replacement (continuation fork) and ripped out that code in 2011 and replaced it with libunbound code