search

xenon-middleware / xenon

A middleware abstraction library that provides a simple programming interface to various compute and storage resources.
http://xenon-middleware.github.io/xenon/
Apache License 2.0
34 stars 17 forks source link

Replace scheduler.jobOptions.JOB_OPTION_JOB_SCRIPT with something else #629

Closed sverhoeven closed 5 years ago

sverhoeven commented 6 years ago

When #628 and #627 are solved then this will be the only value allowed in the JobOption map.

sverhoeven commented 6 years ago

Current plan: Replace submitBatchJob(JobDescription description) with scheduler.submitJob(AbstractJobDescription description). Make the original JobDescription is a subclass of AbstractJobDescription.

Add JobScriptPath class which is a subclass of AbstractJobDescription to submit script with path as location. Add JobScript class which is a subclass of AbstractJobDescription to submit the script content. JobScriptPath and JobScript classes will be specific to the adaptor and should be clearly marked as being an escape hatch.

sverhoeven commented 5 years ago

New plan: Use description.setSchedulerArguments() as an escape hatch. Remove API to submit a job script.

sverhoeven commented 5 years ago

JobOptions property has been removed. So has the job script as a consequence.

For now the only escape hatch is to use the SchedulerArguments methods. If there is a need for script submission a new issue can be created.