xeokit / xeokit-bim-viewer

A browser-based BIM viewer, built on the xeokit SDK
https://xeokit.github.io/xeokit-bim-viewer
Other
406 stars 353 forks source link

Inspect Properties no longer working #169

Open sigurdne opened 6 months ago

sigurdne commented 6 months ago

Seems like the "Inspect Properties" has stopped working. Complaining about "propertySet is undefined" in xeokit-bim-viewer-app/lib/xeokit-bim-viewer/xeokit-bim-viewer.es.js

bilde bilde

xeolabs commented 6 months ago

Seems to work OK for me:

https://xeokit.io/demo.html?projectId=RAC

Screenshot from 2024-03-08 11-12-31

Can I please get some info on how to reproduce? Perhaps:

thanks

sigurdne commented 6 months ago

The IFC was converted some time ago with the command node ~/public_html/xeokit-bim-viewer-app/node_modules/@xeokit/xeokit-convert/convert2xkt.js -s 'H0700 Krohnåstoppen Bofellesskap ARK #67 2023-02-07 1325.ifc' -o geometry.xkt Worked fine a for long time (a year) - until I did a npm update and npm run build

I have also tried the conversion with the original command, and the latest @xeokit/xeokit-convert - with the same result

the xeokit-bim-viewer/package.json reads "name": "@xeokit/xeokit-bim-viewer", "version": "2.4.33", so probably not the correct method for update... I thought maybe the xeokit-bim-viewer-app would fetch the latest xeokit-bim-viewer on update

sigurdne commented 6 months ago

Updated the package.json to:

 "dependencies": {
    "@xeokit/xeokit-bim-viewer": "2.5.1-beta-18",
    "@xeokit/xeokit-convert": "1.1.15-beta-5",
    "commander": "^8.0.0",
    "glob": "^7.1.7",
    "http-server": "^0.12.3",
    "puppeteer": "^10.1.0",
    "rimraf": "^3.0.2"
  }

Did a "npm install" and "npm run build" same result

xeolabs commented 6 months ago

Can you provide the IFC, and the XKT that was converted some time ago?

Then I can debug and make a regression test etc.

sigurdne commented 6 months ago

Where do I put them? (I have one IFC that is converted with properties, and another IFC from the same project that is converter without)

xeolabs commented 6 months ago

Can you attach them to this issue? BTW the direct IFC->XKT conversion mode with convert2xkt is not one that's used much, because it doesn't scale well for large models. We recommend using IfcConvert to convert IFC->gkTF, then convert2xkt to convert glTF to XKT.

sigurdne commented 6 months ago

ARK: converts without properties using convert2xkt RIE: converts with properies

H0700 Krohnåstoppen Bofellesskap ARK #70.ifc.zip H0700 Krohnåstoppen Bofellesskap RIE #48 2023-02-07 1326.ifc.zip

xeolabs commented 6 months ago

ARK: converts without properties using convert2xkt RIE: converts with properies

H0700 Krohnåstoppen Bofellesskap ARK #70.ifc.zip H0700 Krohnåstoppen Bofellesskap RIE #48 2023-02-07 1326.ifc.zip

Are these both converted directly from IFC->XKT using convert2xkt, and no other tools?

sigurdne commented 6 months ago

Yes

sigurdne commented 6 months ago

Tried the IfcConvert to convert IFC->glTF, and then convert2xkt to convert glTF to XKT. The result was missing all custom property-sets from the model. Is there an option to the command to preserve the property-sets?

drashevski commented 3 months ago

@sigurdne a short comment from my side. We with Lindsay recommend using the ifc2gltf converter for production. It is provided here: https://github.com/Creoox/creoox-ifc2gltfcxconverter/releases