search

xerial / sbt-pack

A sbt plugin for creating distributable Scala packages.
496 stars 76 forks source link

Can't run bash scripts #145

Open oyuskiv opened 5 years ago

oyuskiv commented 5 years ago

Can't run bash script if mapped program name contains space character. bat script works correctly. Names of scripts don't contain space character.

There is small example of build.sbt file that leads to run REPL instead of run program.

packMain := Map("hello scala" -> "Test")
lazy val test = (project in file("."))
  .enablePlugins(PackPlugin)
  .settings(
    name := "Test app",
    version := "0.1",
    scalaVersion := "2.12.7",
    )
xerial commented 5 years ago

Generally speaking, program names should not contain any white space. I’m not sure why you need to run a command with a white space.

oyuskiv commented 5 years ago

I agree with you about white space and this issue has very low priority imho. I made report only to notify you about this.

xerial commented 5 years ago

ok. We can sanitize the command name if it contains white spaces for more safety. We will not directly support command names with white spaces, though.