search

xerpi / fakemote

A Wii cIOS module that fakes Wiimotes from the input of USB game controllers
GNU General Public License v2.0
167 stars 16 forks source link

Mark the fake wiimote as inactive before disconnecting it #35

Closed sanjay900 closed 8 months ago

sanjay900 commented 8 months ago

When testing hotplug, i found that unplugging and replugging the controller would sometimes just hang my wii. It was actually this behaviour that was why my guitar hero branch sort of sat stale for so long, as I couldn't really share a build of it with people when it was causing their wii to hang.

However, marking the controller as inactive before unassigning and disconnecting it seems to have fixed this, I was able to unplug and replug my guitar hero guitar without it hanging with IOS57.

Invictaz commented 8 months ago

@sanjay900 will this unassigning to avoid hang also work for other types of controllers and if so, can you push a commit for it?

sanjay900 commented 8 months ago

@sanjay900 will this unassigning to avoid hang also work for other types of controllers and if so, can you push a commit for it?

This change is not specific to guitar hero controllers, it just happens that that is what i noticed it with.

xerpi commented 8 months ago

Looks good to me, thanks!