xfangfang / PPPwn_cpp

C++ rewrite of PPPwn (PlayStation 4 PPPoE RCE)
GNU General Public License v3.0
404 stars 59 forks source link

Little bug in firmware selection #46

Closed deviato closed 6 months ago

deviato commented 6 months ago

There's a little bug that prevents to run the program with fw parameter values other than "base" ones (702 for example). In line 159 you determine the "base" offset by calling auto offset = getFirmwareOffset(fw); but later, in line 176 you try to set firmware offset with: if (exploit->setFirmwareVersion((FirmwareVersion) fw)) return 1; But that function only accepts "base" firmware versions, so it should be if (exploit->setFirmwareVersion((FirmwareVersion) offset)) return 1;

xfangfang commented 6 months ago

Thanks for the PR