xfiveco / generator-chisel

Chisel is a development framework for creating easy to maintain and fast WordPress websites.
https://www.getchisel.co
MIT License
270 stars 37 forks source link

Fix page subgenerator 'spawn gulp ENOENT' error #381

Closed luboskmetko closed 2 years ago

luboskmetko commented 6 years ago

Got the following when trying to create a page while testing Chisel on macOS. However, the page was normally created and entry added to .yo-rc.json

yo chisel:page "Home"
   create src/templates/home.twig                                                                                                                
 conflict index.html                                                                                                                             
? Overwrite index.html? overwrite this and all others                                                                                            
    force index.html                                                                                                                             
All done!                                                                                                                                        
events.js:183                                                                                                                                    
      throw er; // Unhandled 'error' event                                                                                                       
      ^                                                                                                                                          

Error: spawn gulp ENOENT                                                                                                                         
    at _errnoException (util.js:992:11)                                                                                                          
    at Process.ChildProcess._handle.onexit (internal/child_process.js:190:19)                                                                    
    at onErrorNT (internal/child_process.js:372:16)                                                                                              
    at _combinedTickCallback (internal/process/next_tick.js:138:11)                                                                              
    at process._tickCallback (internal/process/next_tick.js:180:9)

Don't know if this is a regular error or something with my setup. But other than that Chisel works fine also on WP projects (after setting up things with Homebrew).

jakub300 commented 6 years ago

Hey, why closing this? This is real bug, probably because page generator is executing gulp rather than yarn/npm build. https://github.com/xfiveco/generator-chisel/blob/d62620ef70e60ee5fb0cf7a4738cf72793a3c6b6/generators/page/index.js#L150

luboskmetko commented 6 years ago

Sorry, there was no response to this so I thought it was just me when I was shortly using Mac. Thanks for reopening.

luboskmetko commented 3 years ago

@jakub300 is this still relevant even in the new version?