search

xh / hoist-core

🏗️ The XH Hoist toolkit for Grails
https://xh.io/
Apache License 2.0
7 stars 2 forks source link

Improve `EmailService` subjects generated for non-prod / overridden deliveries #378

Closed lbwexler closed 3 months ago

lbwexler commented 3 months ago

Went way too deep down this rabbit hole -- but there was nothing else to do but finish it

amcclain commented 3 months ago

Pushed a few additional tweaks + internal typings while reviewing - I read through it and looks like a nice cleanup, but did not run or test myself .

@jskupsik if you have a chance over the next day or two, can you please review and test out the expected use cases so we can safely get this in? Many thanks.