xhluca / bm25s

Fast lexical search implementing BM25 in Python using Numpy, Numba and Scipy
https://bm25s.github.io
MIT License
920 stars 39 forks source link

Add BM25_pt (my library) to the acknowledgement #80

Closed jxmorris12 closed 4 weeks ago

jxmorris12 commented 4 weeks ago

Cool work, thanks for making this useful open-source tool!!

It seems that the central idea behind the scoring mechanism in this library is originally from bm25_pt: https://github.com/jxmorris12/bm25_pt

For example, the APIs are nearly identical

would be awesome if you added an acknowledgement in the README!

xhluca commented 4 weeks ago

Yes that's right! BM25-PT was a big inspiration. I mentioned in the arxiv paper but it's important to add it to the acknolwedgement too.

xhluca commented 4 weeks ago

I added the acknolwedge here: https://github.com/xhluca/bm25s/commit/8b5ff105dc550189412da83be68de9a857b325f5

jxmorris12 commented 4 weeks ago

Thank you 🙏