search

xhs / librtcdc

Tiny portable WebRTC Data Channel in C.
Other
248 stars 40 forks source link

Wrong component id in parse_remote_candidate_sdp() #18

Closed Sfinx closed 8 years ago

Sfinx commented 8 years ago

Why the component id is set to candidates list size which is random value for both endpoints ? According to https://tools.ietf.org/html/rfc5245 the component is definitely fixed value (1 for RTP, 2 - fro RTCP). Such bug leads to the following warning and inability to establish connection between clients that use different libnice versions.

(process:XXXXX): libnice-WARNING **: Could not find component X in stream 1

one liner change fixes the things

int ret = nice_agent_set_remote_candidates(ice->agent, ice->stream_id, 1, list);
xhs commented 8 years ago

Hi @Sfinx , I am a little confusing but the component id is set to 1 now, not random candidate list size.

Sfinx commented 8 years ago

Hi, sorry, seems like I've missed the repo url (TopPano) ;)