xiota / geany-preview

Turns Geany into a markdown editor by providing a preview pane in the sidebar to show the formatting of several light-weight languages as they are edited. Supported document types include AsciiDoc, DocBook, Fountain, HTML, LaTeX, Markdown, MediaWiki, reStructuredText, Textile, and Txt2Tags.
GNU General Public License v3.0
12 stars 0 forks source link

html: background color of the body-tag is respected only for the first snippet #21

Open ralf3u opened 2 years ago

ralf3u commented 2 years ago
<body style="background:gray">

in preview.conf: snippet_html=true

tested with extra_css=extra-media.css and also tested with extra_css=disable

xiota commented 2 years ago

That is because the beginning of the document with the style info gets cut off.

ralf3u commented 2 years ago

That is because the beginning of the document with the style info gets cut off.

So, instead of the code above, the alternative is to add the background color to the css in extra_css in preview.conf that works for all snippets. I'm fine with a wontfix-label on this issue that could be closed.

xiota commented 2 years ago

I'm fine with a wontfix-label on this issue that could be closed.

I'll leave this open because I may look at it eventually. It's just that restructuring the plugin to make it more manageable would have to be done first.

ralf3u commented 2 years ago

It's just that restructuring the plugin to make it more manageable would have to be done first.

@xiota You don't need to fix issues for the actual plugin. I can wait for the redesigned plugin, because all important issues for my needs are fixed, and because I will not start to code in the next ten months. But I still publish issues, so you are informed, so you can maybe think about it to solve it in the redesigned plugin, and so you can test the issue later in the redesigned plugin.

If I recognize that it would be good to fix an issue soon, then I would ask you if it could be fixed in the next weeks.

xiota commented 2 years ago

You don't need to fix issues for the actual plugin. I can wait for the redesigned plugin, because all important issues for my needs are fixed... But I still publish issues, so you are informed...

Thanks for reporting. Just wanted to let you know you're not being ignored.

If I recognize that it would be good to fix an issue soon, then I would ask you if it could be fixed in the next weeks.

That is helpful, like with the shaking problem. So I know what to prioritize.