search

xiota / geanylua-scripts

GeanyLua scripts to add some minor features to Geany. Hide the menubar. Show multiple long-line column markers.
GNU General Public License v2.0
2 stars 0 forks source link

auto-sidebar.lua does not respect fountain any more #5

Closed ralf3u closed 1 year ago

ralf3u commented 2 years ago

steps to reproduce just down below the Mardown-line I added this line in auto-sidebar.lua

 ["Fountain"] = show_sidebar,

I saved the document I restarted Geany

result there is no sidebar when a fountain-document is in the editor; to see the Preview I have to press the shortcut "Toggle Sidebar"

expectation there should be a sidebar when a fountain-document is in the editor

alternative I tried also this line

 ["FOUNTAIN"] = show_sidebar,

and I tried also to put it just before the HTML-line

remark last year it was working, I think so

remark that does not belong to this issue last year the font-color was all in white in the Preview, I think so; but now it is black and white; the black part is too hard to read; I tried to change the color in fountain.css; but it didn't work

ralf3u commented 2 years ago

this does also not work for "Big Fish"

  ["fountain"] = show_sidebar,
xiota commented 2 years ago

So this worked before because I used to have a patch in the PPA that added fountain document type. I submitted a PR upstream to include it, but it was ignored. Geany code changed too much, and the patch no longer works without modification. Since there wasn't any interest in adding support for fountain and I don't really feel like maintaining a patch no one cares about, I dropped the patch.

I'll take a look at the Lua script to see if there's a workaround to work with fountain documents.

ralf3u commented 2 years ago

I see some fountain-documents maybe 5 times a year. For this I can use the shortcut to let appear the sidebar. When reporting, I thought that is was just a small issue that could be fixed easily.

ralf3u commented 2 years ago

remark that does not belong to this issue last year the font-color was all in white in the Preview, I think so; but now it is black and white; the black part is too hard to read; I tried to change the color in fountain.css; but it didn't work

Is there a solution that I could do that the whole text is white again?

xiota commented 1 year ago

There is a file with instructions at ~/.config/geany/filedefs/filetypes.README.

Create ~/.config/geany/filedefs/filetype_extensions.conf with contents:

[Extensions]
Fountain=*.ftn;*.fountain;

Then copy /usr/share/geany/filedefs/filetypes.markdown to ~/.config/geany/filedefs/filetypes.Fountain.conf.

xiota commented 1 year ago

I tried to change the color in fountain.css; but it didn't work

Is there a solution that I could do that the whole text is white again?

I think that is the correct file to edit. Have you already opened an issue for this at geany-preview?

ralf3u commented 1 year ago

Then copy /usr/share/geany/filedefs/filetypes.markdown to ~/.config/geany/filedefs/filetypes.Fountain.conf.

Are you sure about this line? I ask because there are different formats in the same line.

xiota commented 1 year ago

Then copy /usr/share/geany/filedefs/filetypes.markdown to ~/.config/geany/filedefs/filetypes.Fountain.conf.

Are you sure about this line? I ask because there are different formats in the same line.

Using filetypes.markdown as a template for filetypes.Fountain.conf. Otherwise, you would need to create the new file from scratch.

For changes to take effect, close any open fountain files. Then close and restart Geany. Reopen the fountain files.

If you see fountain files with different extensions, you can rename them or add the new extensions to filetype_extensions.conf.

ralf3u commented 1 year ago

I did https://github.com/xiota/geanylua-scripts/issues/5#issuecomment-1446853464. At the moment in my geanylua-file there is only the old version of auto-sidebar. But auto-sidebar still does not respect fountain.

ralf3u commented 1 year ago

Sorry for my last comment. I forgot to do this: In auto-sidebar.lua I just added this line in the section local action_tbl, like it is mentioned in the report, on top of this webpage:

 ["Fountain"] = show_sidebar,

Now it works.

xiota commented 1 year ago

When you get a chance, try the new auto-sidebar. It respects the sidebar state (issue #3) when used with the toggle-sidebar script. It shares some files with switch-views and uses sidebar_restore in action_tbl.

ralf3u commented 1 year ago

When you get a chance, try the new auto-sidebar. ...

Yes, this is what I wanted to do the next days.