Cleanup source, fix peerDependencies and generate CommonJS, ESM & UMD bundles - Githubissues

xlsdg / vue-countup-v2

Vue.js component wrap for countUp.js

https://inorganik.github.io/countUp.js/

MIT License

379 stars 56 forks source link

Cleanup source, fix peerDependencies and generate CommonJS, ESM & UMD bundles #9

Closed VitorLuizC closed 5 years ago

VitorLuizC commented 5 years ago

Cleanup your component source
- Remove comments
- Remove methods available through instance property
- Remove that usage, use this instead
- Remove redundant prop options
- If default is defined you don't have to define required: false (source)
- If required is false and there's no default you can use just the constructor (source)
Fix peerDependencies by use package versions (Vue 2.x and CountUp 1.x)
Generate CommonJS, ESM & UMD bundles and point to them on package.json