search

xmppo / node-expat

libexpat XML SAX parser binding for node.js
https://github.com/xmppo/node-expat
MIT License
384 stars 97 forks source link

fix: return `this` from `destroy()` #214

Closed danielroe closed 1 year ago

danielroe commented 3 years ago

For consistency with Node stream implementations, destroy() should likely return this - https://nodejs.org/api/stream.html#readabledestroyerror (for example).

Context: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/57473