xmtp / example-chat-react

This repo has been archived. Replacement apps include the XMTP Quickstart React and XMTP Inbox chat apps. For more details and links, see the README in this repo.
MIT License
74 stars 52 forks source link

changes to support infinite scroll and pagination in messages #138

Closed bhavya2611 closed 1 year ago

bhavya2611 commented 1 year ago

This PR adds

  1. Pagination for messaging
  2. Infinite Scroll for messages
  3. Local Storage Support
  4. Universal Inbox Support
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
example-chat-react ✅ Ready (Inspect) Visit Preview Dec 1, 2022 at 7:24AM (UTC)
cloudflare-workers-and-pages[bot] commented 1 year ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: df78a76
Status: ✅  Deploy successful!
Preview URL: https://77be4c1e.chat-3hb.pages.dev
Branch Preview URL: https://feat-message-pagination.chat-3hb.pages.dev

View logs

jhaaaa commented 1 year ago

Hi there @bhavya2611 - thank you for this! As requested, doing some testing. =)

When I start a conversation with an address that is on the network, but which I've never messaged before, the app doesn't display the "Type something..." field at the bottom of the screen.

image

The app does display the field for existing conversations:

image

bhavya2611 commented 1 year ago

@jhaaaa resolved your issue

jhaaaa commented 1 year ago

Hi there @bhavya2611 - thank you! Yes, I can now enter an address that is on the network, but which I've never messaged before and the "Type something" field displays.

However, when I send the message, it doesn't display in the sender view and a new conversation does not display for the recipient. Here's a little GIF that shows what I'm talking about:

2022-11-27_09-23-35 (1)

Any thoughts? =) Thank you!

neekolas commented 1 year ago

It doesn't appear that deep links work with these changes. We've updated the URLs to include conversationId, but when I refresh the page no conversation loads.