xopxe / bbl-twitter

Barebones Lua Twitter
MIT License
16 stars 5 forks source link

Changes needed to work with API ver. 1.1 #1

Open xopxe opened 10 years ago

xopxe commented 10 years ago

Hi, I branched your project (https://github.com/xopxe/bbl-twitter) and made some changes:

  1. The module is returned as a table, with no global pollution
  2. Made twitter api version 1.1 compatible:
    • Some URL changed
    • Moved to use https (adds dependecy on LuaSec)

An example program now is as follows:

local bbl = require("bbl-twitter")  
local config = {  
  consumer_key = 'xxx',   
  consumer_secret = 'xxx',  
}  
local c = bbl.client(config.consumer_key, config.consumer_secret)  
-- The following function will prompt on the console to visit a URL and  
-- enter a PIN for out-of-band authentication  
bbl.out_of_band_cli(c)  

bbl.update_status(c, "Look ma, I just authenticated my Lua twitter app!")  
print(string.format("Authorized by user '%s'. My secrets are token_key '%s' token_secret '%s'",  
  c.screen_name, c.token_key, c.token_secret))  
projectgus commented 10 years ago

Hi xopxe,

Nice work, they all look like great enhancements!

As you probably noticed I haven't worked on this library in a long time. Would you like to become the new maintainer? I will happily delete my fork in favour of yours if you like.

If you'd rather not, that's fine too. I'll merge your changes (with thanks) for anyone else who comes across this project.

Cheers,

Angus

xopxe commented 10 years ago

Hi Angus,

I have no problem maintaining the project. I'm not sure how is the etiquette in these cases. I guess putting "Originally created by XXX, currently being maintained by YYY" in the README, no? How would you like to be credited (name, email, link to github profile)?

And thanks again for this great service

matthijskooijman commented 10 years ago

Folks, you might want to see if you can transfer ownership of this repo instead of deleting it, to move over any issues/pullrequests/etc. I believe that will also set up a redirect from the old url to the new one, which is probably desired.

projectgus commented 10 years ago

Thanks Matthijs, I didn't actually realise github had this feature.

@xopxe - "Originally created by Angus Gratton (@projectgus), currently..." in the README is fine. Even without being current maintainer, you'll probably want to add your name & 2014 to the copyright statements as well (something like

(C) 2014 Jorge
(C) 2011 Angus Gratton

... is normal for most open source projects I think.)

I'll go and try to transfer now, I suspect there will be some additional steps before it "just works"...

projectgus commented 10 years ago

It won't let me transfer to you while you have a repository of the same name.

I've merged your changes (thanks again!), and I updated the README file a bit to (hopefully) use the new style and mention you as the new maintainer.

If you delete your repository and let me know here, I'll transfer this repository to you.

xopxe commented 10 years ago

Done, I just deleted my fork.

xopxe commented 10 years ago

Ok, seems everything is in place. Thanks Angus again, and also to Matthijs for the tip!