xorbitsai / xoscar

Python actor framework for heterogeneous computing.
https://xoscar.dev
Apache License 2.0
89 stars 21 forks source link

BUG: append subpool logging #77

Closed UranusSeven closed 1 year ago

UranusSeven commented 1 year ago

What do these changes do?

Subpools created by append_subpool do not have correct logging config.

Related issue number

Fixes #xxxx

Check code requirements

codecov[bot] commented 1 year ago

Codecov Report

Merging #77 (498274a) into main (17881dd) will decrease coverage by 0.24%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   89.35%   89.12%   -0.24%     
==========================================
  Files          48       48              
  Lines        4012     4008       -4     
  Branches      764      763       -1     
==========================================
- Hits         3585     3572      -13     
- Misses        344      351       +7     
- Partials       83       85       +2     
Flag Coverage Δ
unittests 88.94% <ø> (-0.24%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
python/xoscar/backends/indigen/pool.py 95.39% <ø> (+0.82%) :arrow_up:

... and 3 files with indirect coverage changes