search

xoseperez / espurna

Home automation firmware for ESP8266-based devices
http://tinkerman.cat
GNU General Public License v3.0
3k stars 636 forks source link

3rd party libraries usage for sensors #1668

Closed berezovskyi-oleksandr closed 5 years ago

berezovskyi-oleksandr commented 5 years ago

Hi!

I want to implement support of Bosch BME680 sensor support. I took a brief look on datasheet and current implementation of BMX280 and there are lots of different things over there.

Bosch provide ready-to-use library for this sensor and it used in Adafruit library for Arduino.

Is it ok to add 3rd party library and implement just bindings for sensor support?

mcspr commented 5 years ago

Sorry for delayed response.

I don't think that would be a problem, unless there are some catastrophic issues with the way it works. Also note that Adafruit library implicitly pulls Adafruit_Sensor library as a dependency: https://github.com/adafruit/Adafruit_BME680 https://github.com/adafruit/Adafruit_Sensor

Judging from https://github.com/adafruit/Adafruit_BME680/pull/22, there's also a problem with async reading when millis() timer overflows (49 days uptime) Which it a likely way to make readings work here.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] commented 5 years ago

This issue will be auto-closed because there hasn't been any activity for two months. Feel free to open a new one if you still experience this problem.