search

xou816 / spot

Native Spotify client for the GNOME desktop
MIT License
2.3k stars 126 forks source link

⚠️ Current maintenance policy -- read for issues and PR submissions #591

Open xou816 opened 1 year ago

xou816 commented 1 year ago

(work in progress)

Submitting issues/feature requests

There's a bit (ahem) of catching up to do regarding issues and pull requests. Please allow us to work through it! Bug fixes will be prioritized over new features for the time being.

For reviews, please involve one of the following people and allow us time to review, as we're all busy people :)

@xou816 @Diegovsky @knokelmaat

For new features that you'd like to implement yourself, please start with an issue so we can flesh out together which way to go. This will save time for everyone :)

Maintainers

If you'd like to start/stop being involved in some of the maintenance effort, please signal yourself below, I'll add/remove you to the list :)

Tasks we could use some help with:

I'm still thinking about how to handle permissions. For now, it's likely that I'll still have to be the one to hit merge -- but I'll try to defer as much as possible to maintainers and trust your reviews.

xou816 commented 1 year ago

this week I'll try to go through open PRs that seem close to ready and then bugs

there are a couple dependencies update to handle but nothing too bad!

we need to have a look at pull transations from poeditor as well :)

samsapti commented 1 year ago

@xou816 just a small suggestion: Maybe you could give co-maintainers write access to the repo, but only you have write access to the development and master branches? That would be easy to do with branch protection rules. It would also ease the task of reviewing and fixing/editing PRs.

Diegovsky commented 1 year ago

For now, it's likely that I'll still have to be the one to hit merge

I'm all aboard with this! IMHO your vision of the project is what goes :)

knokelmaat commented 1 year ago

Hey, I am the one who put op the post on /r/gnome. I would also like to contribute if needed. I don't have much experience with Github, but I'll see what I can do. I'll start by just cloning and getting everything working on my end :smile: .

Also, might it be interesting to have some sort of chat room for quick development conversations (like asking for help with a certain error or stuff like that)? Going through github issues might be a bit of a barrier for small things that are just needed to get going.

I would certainly like to help accommodating that! I quickly made a space on matrix for example: https://matrix.to/#/#spot-devel:matrix.org

xou816 commented 1 year ago

@xou816 just a small suggestion: Maybe you could give co-maintainers write access to the repo, but only you have write access to the development and master branches? That would be easy to do with branch protection rules. It would also ease the task of reviewing and fixing/editing PRs.

I haven´t quite figured out how to do that with non-pro/non-org GitHub (maybe it's not possible) but ah, no big deal, I'll open write access progessively, it should be fine :)

Hey, I am the one who put op the post on /r/gnome. I would also like to contribute if needed. I don't have much experience with Github, but I'll see what I can do. I'll start by just cloning and getting everything working on my end smile .

Oh hey thanks, glad to see you here! thanks for your support!

Also, might it be interesting to have some sort of chat room for quick development conversations (like asking for help with a certain error or stuff like that)? Going through github issues might be a bit of a barrier for small things that are just needed to get going. I would certainly like to help accommodating that! I quickly made a space on matrix for example: https://matrix.to/#/#spot-devel:matrix.org

sure, that is a great idea! I'll join!

Diegovsky commented 1 year ago

@xou816 what do you think about giving someone temporary write access to the project? Currently, I have some spare time and would love to merge some PRs, add features, etc.

This way, if you're feeling burnt out, you can count on someone to have your back and manage the project while you're out :)

nonetrix commented 10 months ago

Good to see things are starting to move again even if slowly, the main thing that stops me from using this is not having liking feature personally. Of course the main focus should be to bug fix and update everything, but I think that would be the single most meaningful change personally. I might consider helping out perhaps, I have been meaning to finish to Rust book and learn gtk-rs for a while now, seems like a good excuse

Diegovsky commented 10 months ago

Feel free to! I would be happpy to review/help writing the code anytime :)

Diegovsky commented 10 months ago

Hello, everyone. To keep Spot maintained and to add more features, ~I'm pulling all the PRs into my maintained fork. I'll be trying to maintain it there for a while while xou816 is on a hiatus.~

Feel free to open an issue or PR ~over here this :)~

Edit: see comment below

Diegovsky commented 9 months ago

Hello, everyone. To keep Spot maintained and to add more features, I'm pulling all the PRs into my maintained fork. I'll be trying to maintain it there for a while while xou816 is on a hiatus.

Feel free to open an issue or PR over here :)

I noticed I have write access to branches I create. Please, take a look at my maintenance branch. I will be resuming development from this repo instead!

Diegovsky commented 7 months ago

Hello, everyone. I just merged a new PR in the manifest repository to track changes from my branch.

Basically, (I think) I released a new version of Spot. Sorry for the wait!

Diegovsky commented 7 months ago

I'm a bit busy with uni, but I intend to work on spot every once in a while when I have time.

If you're passionate about the project and want to contribute: open a PR and ping me! I'll make sure to review it once I have the time :)