crschnick
commented
2 weeks ago Thank you for your detailed investigation! To answer your questions:
- The first issue where XPipe can't find it in the PATH seems to be somewhat related that XPipe is calling
shinstead ofzsh. It only does that if you explicitly enable the fallback shell under the local shell settings or the zsh initialization failed. Can you check that setting? - About the traling output, it seems like I missed that back when I implemented dashlane support. I can fix that
- The trailing spaces for passwords issue can also be fixed
btbutts
Hello XPipe Devs,
XPipe seems to not always necessarily respect $PATH as defined in MacOS ~/.zprofile. Note that I did install XPipe via homebrew (
brew install --cask xpipe-io/tap/xpipe). Moreover, I also installed my Dashlane CLI password manager utility dcli via homebrew (brew install dashlane/tap/dashlane-cli), as well as iTerm2 via (brew install --cask iterm2).After determining the path for XPipe and DashlaneCLI via: $: which xpipe /usr/local/bin/xpipe $: which dcli /opt/homebrew/bin/dcli
I was able to confirm that both /usr/local/bin & /opt/homebrew/bin are in fact included in $PATH via checking
echo $PATH! Furthermore, if I simply run dcli commands from a terminal without sudo, there are no path errors. It works just fine. This should imply that my $PATH variable is setup correctly.Interestingly, when I view the XPipe settings tab > then "Password manager" and choose Dashlane from the templates drop-down menu, I can leave the default template command syntax
dcli password --output console $KEYand enter one of my account key_names to test under the Test password manager section and that works just fine. There are no errors there whatsoever. Therefore, at least for the XPipe app itself, it has no issues calling executables located in $PATH.However, after saving that default password manager command syntax and then attempting to use the "Password manager" option when defining the account authentication settings for a new Simple SSH Connection, using the appropriate Dashlane account keyname in place of the XPipe variable $KEY_, I receive the following error:
Basic Error
Error Details
I receive this error after adding a new Simple SSH Connection and submitting the config so that XPipe can scan the host for services it can connect to. In this situation, no terminal has been started yet, at least not via my chosen emulator iTerm2. That said, after the failure, If I skip it and just try to open an SSH session to the host, I also receive the exact same error above, line for line. Therefore, at a surface level, it would appear as if XPipe's initial SSH session startup script that's launched during each new SSH session is not respecting the user's $PATH, thus the dcli: command not found failure shown above.
Now I can modify the Password manager command syntax so that the full path to
dcliis specified (/opt/homebrew/bin/dcli password --output console $KEY) in the XPipe settings, which will remove the command not found errors I described above. However, that's when I noticed another issue...It would appear that the default Dashlane template is incomplete. Since XPipe expects to receive only one line in response to the password query and no trailing spaces "apparently", I see that you all have configured the
--output consoleoption for thedcli passwordcommand. Unfortunately,--output consoledoes not replace the default output method (copy to clipboard) in which a message is also displayed in the terminal alerting the user to the fact that their retrieved password is in their clipboard. That message is displayed in addition to the printed password. For example:Since two lines are provided in response, the response fails. The following errors are returned by XPipe:
Basic Error
Error Details
Because Dashane's dcli tool simply appends the "password in clipboard message" to a new line after the printed password string from the
--output consoleflag, the existing dcli template command flags are insufficient.dcli password --output console $KEYjust won't do!I piped the output of this template to
awkto remove all but the first line (the printed password string) via:9 times out of 10, piping the default dcli template to awk as shown above resolved the issue and my SSH Connection could now establish using the dcli password manager template (mind you with the full path to dcli defined too). However, I did find that sometimes, I would still get authentication failures when I knew the password was correct. Apparently, XPipe, or some process or something else initialized by XPipe is adding whitespace to the end of passwords. This can be easily reproduced by running the Test password manager in the XPipe settings as there will be at least four spaces after each password returned from the test, regardless of the length. Therefore, I made an additional command modification via:
The trailing
sed 's/\s+$//'after the second | will remove all traces of whitespace after the password, if any exists. If there is no whitespace after the password, the password is still displayed as-is.In order for your Dashlane Password manager template to be accurate, and to work, this should be updated, or perhaps documented somewhere. I couldn't find anything on this issue in github or the XPipe Docs so I had to tinker with it until I discovered all of this. I hope all this helps!
Thanks, -Brian