search

xplodwild / android_packages_apps_Focal

Open Source Android Camera App | don't forget android_external_Focal repo
Other
492 stars 253 forks source link

Recent picture preview makes it too easy to delete pictures #66

Open axelsimon opened 9 years ago

axelsimon commented 9 years ago

Hi there,

When pulling down from the top of the screen, you get a preview of recently taken pictures. From the ovrelay preview you can both view recent pictures and delete them.

It took me a while to realise that swiping left and right browsed through the pictures while swiping pictures up or down actually deletes them. When one swipes up or down on a picture, no message appears warning that the picture has been deleted. No “undo” message appears either.

It took me a few lost pictures to realise this behaviour was happening.

I suggest: 1/ making the deletion of pictures a lot more obvious and visible 2/ adding an undo function, right now it's pretty unforgiving 3/ only allowing downward swipe on photos to delete them, not upward swipe. Rationale: swiping down is used to pull down the recent pictures preview, one would expect the opposite swipe up to close that overlay. Instead, it deletes pictures. Only swiping down to delete pictures would make it more logical, IMHO.

BTW, I've also realised than in certain cases, previewing the photos, half swiping them up or down, then closing the preview overlay leaves a ghost picture over the camera's main screen / viewfinder. If I figure how to reproduce it I'll report it more thoroughly.

Thanks!

axel

hydrargyrum commented 9 years ago

I second that. While in camera mode, I swiped down and I was dropped into a kind of photo browser, without any message explaining what it did. I just assumed I could view photos, so I tried swiping in all directions, there was no indication of what was happening, no help, no warning, no confirmation, just nothing. As it was very unclear and un-practical, I switched to the regular file browser from Android, only to discover that Focal had destroyed some of my pictures, not only some I had just taken.

This is an extremely grave issue.

My opinion is that swiping should not delete anything at all, only a button with a clear icon and a confirmation dialog should be able to do that.

peterf81 commented 8 years ago

It is really not a straightforward feature, it took me also some time to grok that the photos are gone . I like the feature, but at least a background popup message should appear "photo was deleted, press here to undo deletion" . but i like the possibility to delete photos one by one without confirming .