search

xpsi-group / xpsi

X-PSI: X-ray Pulse Simulation and Inference
Other
34 stars 21 forks source link

precisions argument should be an argument in load_runs? #393

Open Basdorsman opened 2 months ago

Basdorsman commented 2 months ago

Let me know if you agree!

Currently precisions is an argument in xpsi.PostProcessing.CornerPlotter.plot that allows you to change the precision of the credible intervals of each parameter. However, I think it should be an argument in xpsi.PostProcessing.Runs.load_runs.

With my suggestion, you would first (ideally optionally) define the precisions for each parameter, and then later decide with parameters you actually plot in your corner plot. Without my suggestion, you have to redefine the precisions each time you want to plot a new subset of parameters.

thjsal commented 2 months ago

I agree, moving it to the load_runs sounds like a good idea.