xrmx / uwsgitop

top-like app for monitoring uWSGI instances
MIT License
496 stars 77 forks source link

uwsgitop colors #37

Closed offline closed 9 years ago

offline commented 9 years ago

After updating to lastest version, I see all lines in red. Is it should be like that? screenshot from 2015-10-14 14 40 05

xrmx commented 9 years ago

The red matches the code:

            if worker['rss'] == 0:
                color = curses.color_pair(3)

Now, does the older version show something in the rss / vsz fields? It would be nice not having magic numbers for color pairs.

offline commented 9 years ago

Here is the old uwsgitop reading the same stat file

screenshot from 2015-10-14 15 01 57

So the problem is I'm reading old version of stat file with newest uwsgitop?

xrmx commented 9 years ago

Nope :) everything is fine. The question is: is red for everything better than the old one? it looks like a no to me. Next is to go looking at the git history figuring out the why this has been changed. I suppose empty rss was seen as a warning of some issue. So we need to sort out if rss being zero is a bug or is it normal. Want to help? :) UPDATE: this last step means actually looking at the uwsgi stats server code and figure out how and when rss and vsz are collected

offline commented 9 years ago

Yes, I joined uwsgi irc channel, my nickname is "offline"

xrmx commented 9 years ago

So the feature is: you'll get everything red unless you enable memory-report in your config. I think this is fine but it should be documented. @offline care to update the README.rst please?