search

xrmx / uwsgitop

top-like app for monitoring uWSGI instances
MIT License
496 stars 77 forks source link

Not having memory reporting enabled lead to full-red color #41

Closed unbit closed 8 years ago

unbit commented 8 years ago

In this line:

https://github.com/xrmx/uwsgitop/blob/master/uwsgitop#L271

we check for rss == 0, and if true the color of the curses pair is set to red.

Unfortunately if no memory-reporting is enabled, rss is always 0

xrmx commented 8 years ago

Yep, it's event documented in the README. Are you suggesting to stop handling the case?

unbit commented 8 years ago

The main problem is that i am not quite sure that checking for rss == 0 for marking a reload is a reliable approach

xrmx commented 8 years ago

Agreed, then let's just kill it.