xsc / lein-ancient

Check your Projects for outdated Dependencies
MIT License
561 stars 33 forks source link

How do we make it work with s3-wagon-private? #100

Closed coreagile closed 3 years ago

coreagile commented 6 years ago

Using [lein-ancient "0.6.15"]

I am getting the following error when running lein ancient (deploy works fine): (error) Assert failed: (not (empty? path))

When reversing the following diff (sensitive information elided):


index 1c44e55..f54f305 100644
--- a/project.clj
+++ b/project.clj
@@ -37,9 +37,6 @@
-  :repositories [["private" {:url           "s3p://--elided--/"
-                             :no-auth       true
-                             :sign-releases false}]]
   :java-source-paths ["src/main/java" "src/test/java"]
   :source-paths ["src/main/clojure"]
   :test-paths ["src/test/clojure"]
@@ -51,6 +48,5 @@
                              [lein-bikeshed "0.5.1"]
                              [lein-dotenv "1.0.0"]
                              [lein-junit "1.1.8"]
-                             [lein-kibit "0.1.6"]
-                             [s3-wagon-private "1.3.1"]]
+                             [lein-kibit "0.1.6"]]
               :dependencies [[junit/junit "4.12"]]}})```
eigenhombre commented 6 years ago

A workaround is to change "s3p://--elided--/" to "s3p://--elided--//" (add extra trailing slash).

xsc commented 3 years ago

Hello! It has been a while, but recent changes to ancient-clj now allow usage of any Maven wagon for resolution. If you're still interested in this, could you verify the behaviour using [lein-ancient "1.0.0-RC1"]?

tobiasadam0770 commented 3 years ago

I had the exact same problem as described in this issue and updating to "1.0.0-RC1" worked for me. Thanks a lot for providing a fix! 🥇 🎉 😀

xsc commented 3 years ago

@tobiasadam0770 Thanks for reporting back! I'll close the issue then.