xtensor-stack / Xtensor.R

R package for xtensor-r
http://quantstack.net/xtensor
Other
17 stars 7 forks source link

Fixes to please cran #5

Closed DavisVaughan closed 5 years ago

DavisVaughan commented 5 years ago

I've added a few changes that should make this a bit more CRAN compatible + make it easier for people who use RStudio.

I also want to take a look at:

SylvainCorlay commented 5 years ago

Wow tganks! This is really super helpful. Really happy to see you help us with best practices.

For the travis simplification, I would lean to making it in a separate PR, as it is probably going to require some iterations. I would like to keep the conda-based approach for the pure c++ xtensor-r package as it follows the same pattern as xtensor-python and xtensor-julia.

DavisVaughan commented 5 years ago

Sounds good!