search

xtensor-stack / xtensor-fftw

FFTW bindings for the xtensor C++14 multi-dimensional array library
BSD 3-Clause "New" or "Revised" License
48 stars 16 forks source link

Add dependencies versions requirement. #42

Closed kokarez closed 4 years ago

kokarez commented 5 years ago

xtension-fftw can't support all version of xtensor so let's start the same system of versioning that is done by xtensor. The xtl/xtension version match the one on current master of xtension, and the fftw3 version match the last stable release. (which is available on Ubuntu)

egpbos commented 5 years ago

Thanks for trying to fix this and also #44 ! Once you think they are ready to merge, ping me so I can review it. I may not have time immediately, but I'll do it asap, probably on Monday (GMT+1 here).

kokarez commented 5 years ago

Not sure how you manage the release but is it possible to push a new release of xtensor - with the -fnoexception ? (on couda too).

kokarez commented 5 years ago

Thanks for trying to fix this and also #44 ! Once you think they are ready to merge, ping me so I can review it. I may not have time immediately, but I'll do it asap, probably on Monday (GMT+1 here).

Ping :) (FYI I'm french) I decide to debug that until I felt asleep.

egpbos commented 5 years ago

Not sure how you manage the release but is it possible to push a new release of xtensor - with the -fnoexception ? (on couda too).

@JohanMabille @SylvainCorlay is this possible? @kokarez what do you need it for?

kokarez commented 4 years ago

@kokarez what do you need it for?

We are converting some xtensor code to support no-exception.

xtensor patch: https://github.com/xtensor-stack/xtensor/commit/ddf1d0bb021feeca632804adeac20942dc8927bf xtl: https://github.com/xtensor-stack/xtl/pull/148

I will check on the xtensor side for the release :)

kokarez commented 4 years ago

The windows is failing due to: https://github.com/xtensor-stack/xtensor/issues/1878

SylvainCorlay commented 4 years ago

Please drop win-32 in the test matrix. We are not making conda-forge packages for win-32 anymore.

kokarez commented 4 years ago

Ok doing it rigth now

kokarez commented 4 years ago

Fixed!

kokarez commented 4 years ago

fixed

SylvainCorlay commented 4 years ago

@egpbos I am not sure we wanted ^0.21 since it also works with ^0.20.10...

egpbos commented 4 years ago

Yes, let's keep the dependencies loose in Conda at least. In CMake it seems we cannot specify minimum dependencies. Probably the best way to do that in CMake is for the dependency package (xtensor in this case) to specify feature tags or something like that.