Open jblespiau opened 2 years ago
Hi,
Sorry for the late reply. The issue is indseed dut to the lack of coparison operators for the slices, that's something we should add in xtensor.
Regarding the upgrade to C++17, it has been discussed for xtensor. However, the XTL is also used by libraries which needs to support C++11/14, thus the need for a backport of std::variant
. We are happy with this backport (easier to update than retrieving it from a huge library), but we could definitely add a "selection" layer here, that will simply use the standard implementation when available.
It's as simple as doing:
xt::all() == xt::all()
The type is defined as:
As a side-note, I was wondering if we should upgrade to C++ 17 to use std::variant instead of a backport. Another altnertive would be to use e.g. https://github.com/abseil/abseil-cpp/blob/master/absl/types/variant.h which will be an alias to
std::variant
when available.