xuorig / prg-feedback

Feedback / corrections for http://book.productionreadygraphql.com/
1 stars 0 forks source link

Page 171 Broken links #14

Closed amaurycrickx closed 4 years ago

amaurycrickx commented 4 years ago
  1. Link includes canadian locale

    A great example of this is Stripe’s approach to versioning. https://stripe.com/en-ca/blog/api-versioning -> link is not broken but locale should be removed as the server issues a redirect to the rewritten url: In my case, I got a dialog at the bottom of the page asking me if I wanted to switch country

  2. Broken link

    For example, the GitHub API allows clients to specify a custom media type that includes a version number. https://developer.github.com/v3/media/%23request-specific-version

  3. Broken link

    In fact, Shopify adopted a URL versioning approach to evolve their GraphQL API. https://help.shopify.com/en/api/versioning%23the-api-version-release-schedule

xuorig commented 4 years ago

Good catches, fixed in v1.2