xuri / xgen

XSD (XML Schema Definition) parser and Go/C/Java/Rust/TypeScript code generator

BSD 3-Clause "New" or "Revised" License

313 stars 74 forks source link

fixed upper case first rune for Unicode #41

Closed yury-egorenkov closed 2 years ago

yury-egorenkov commented 2 years ago

before it produces mess for Cyrillic tag names

Thank you for your library!

PR Details

I used this library to convert XSD on with Cyrillic (cp1251) characters.

Description

Unfortunately, it produces the wrong result in the image below.

I fixed MakeFirstUpperCase function to convert Unicode characters properly.

Now it's correct.

Raw XSD file for testing.

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

xuri commented 2 years ago

LGTM, thank you.