search

xvik / gradle-quality-plugin

Gradle quality plugin for Java and Groovy
http://xvik.github.io/gradle-quality-plugin
MIT License
134 stars 11 forks source link

Present results after running all quality plugins #7

Closed ruairiquinn closed 6 years ago

ruairiquinn commented 6 years ago

Would it be possible to run all quality plugins and display the results at the end, so that all failures can be addressed in one attempt, rather than as each individual plugin fails?

xvik commented 6 years ago

You can disable strict mode to see all errors at once: quality.strict = false. But, ofc, this will not fail the build.

From my experience, it's simpler (psychologically) to process issues at smaller portions compared to fixing everything at once. When you fix code, lines are shifted and some fixes implicitly fix other issues.. and so on.. I don't remember any case when I have a lot of issues and fix them at once, I always have to run tools again after some time. Also, many pmd and checkstyle checks are the same so there will be a lot of duplicate issues (and you will have to spent some time to understand duplication).

Technically it's possible to implement, but I don't see enough reasons to do it: if you want to see everything you can disable strictness and if you want to fix issues then "fix for each tool" approach is much better.

But your experience may be different then mine (depends on project), so please tell me if you see really good reasons for this feature.

ruairiquinn commented 6 years ago

Thanks for your quick response. The issue may be specific to how our project is configured. There are a number of other tasks (e.g. Jacoco, Spotless) which run before the quality task, so having it fail is quite expensive. I think passing a command-line argument to set quality.strict = false is a decent workaround to use locally (knowing it won't fail the build). Thanks.