search

xwidghet / stepmania

Advanced rhythm game for Windows, Linux and OS X. Designed for both home and arcade use.
http://www.stepmania.com/
19 stars 10 forks source link

fix for Lua-specified sound files on ScreenSelectMusic #54

Closed RhythmLunatic closed 6 years ago

RhythmLunatic commented 7 years ago

Basically this bug seems to have never been fixed in 5.0.X, can you add it to Etterna?

https://github.com/stepmania/stepmania/issues/1347

MinaciousGrace commented 7 years ago

ok I looked over this quickly, it should be straightforward to implement the actual fix part of the commit, however I'm traveling and haven't had the chance to set up anything dev related so it'll have to wait until I get that chance unless one of the other devs wants to do it before then

I suppose I could just make the fix blind and pr it to make sure it compiles, but that sort of seems irresponsible

RhythmLunatic commented 7 years ago

I added the fix myself, but it causes another bug where if you scroll over a song and then switch back to the folder quickly it will stop playing the folder music.

Additionally if the song doesn't have a preview file (BMSes usually don't) it will stay muted until you scroll over a song that does have one and then back.

nico-abram commented 6 years ago

Does that also happen on vanilla?

RhythmLunatic commented 6 years ago

If you mean regular StepMania, yes. The master branch has the muted preview bug, or something like it. https://github.com/stepmania/stepmania/issues/1561