xxfxxf / chromiumembedded

Automatically exported from code.google.com/p/chromiumembedded
0 stars 0 forks source link

Add default JS prompt dialog implementation #402

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Using a recent trunk of CEF (trunk r252) I noticed an issue with the prompt JS 
dialog. they just don't appear when the function is used. I foun this in the 
debug.log file that looks somehow related (it appears each time the prompt 
function is called) :
{{{
[1101/175834:INFO:CONSOLE(0)] "event.layerX and event.layerY are broken and 
deprecated in WebKit. They will be removed from the engine in the near 
future.," source: (1)
[1101/175834:INFO:CONSOLE(0)] "event.layerX and event.layerY are broken and 
deprecated in WebKit. They will be removed from the engine in the near 
future.," source: (1)
}}}

Original issue reported on code.google.com by raynaudq...@gmail.com on 1 Nov 2011 at 5:07

GoogleCodeExporter commented 9 years ago
What operating system are you using?

There is no default prompt implementation in CEF, you need to implement it 
yourself using CefJSDialogHandler::OnJSPrompt().

Original comment by magreenb...@gmail.com on 1 Nov 2011 at 5:12

GoogleCodeExporter commented 9 years ago
I'm using Windows 7 and compiling with VS2010.

I'm sorry if that is so. I was confused by the documentation going along with 
the CefJSDialogHandler::ONJSPrompt() function that reads :
Called to run a JavaScript prompt request. Return false to display the default 
prompt or true if you displayed a custom prompt.

I assumed that there was an implementatioCalled to run a JavaScript prompt 
request. Return false to display the default prompt or true if you displayed a 
custom prompt.It made me assume there was one.

Original comment by raynaudq...@gmail.com on 1 Nov 2011 at 5:16

GoogleCodeExporter commented 9 years ago
I'm sorry, I pasted text in my sentence by mistake instead of deleting the long 
part... It should have been : "It made me assume there was one." only.

Original comment by raynaudq...@gmail.com on 1 Nov 2011 at 5:18

GoogleCodeExporter commented 9 years ago
I run the code to fin out that there was a TODO in it exactly where the default 
prompt implementation should have been... I'm sorry for the loss of time... I 
should have debugged this before.

Original comment by raynaudq...@gmail.com on 1 Nov 2011 at 5:22

GoogleCodeExporter commented 9 years ago
No problem, changing the summary to match the request.

Original comment by magreenb...@gmail.com on 1 Nov 2011 at 5:25

GoogleCodeExporter commented 9 years ago
This is supported in CEF3.

Original comment by magreenb...@gmail.com on 2 Oct 2012 at 10:37