search

xxxcucus / planes

Variant of battleships game
MIT License
30 stars 9 forks source link

Verify german texts for Android app #20

Open xxxcucus opened 1 year ago

xxxcucus commented 1 year ago

I wrote the texts myself but as I am no native German speaker I would like to have some feedback about the german texts. The path to the texts is: app\src\main\res\values-de\strings.txt

IunaIuna commented 1 year ago

Hello! I am a German native speaker and would like to give feedback about the German texts. As I am planning to participate at Hacktoberfest would you be so kind and add the topic hacktoberfest to your repository?

Cheers Iuna

xxxcucus commented 1 year ago

No problem. Just added hacktoberfest as topic.

IunaIuna commented 1 year ago

Thank you :) Would you assign me to the issue?

xxxcucus commented 1 year ago

I have merged the pull request. You have corrected the texts in the Java Android App.

These are only some of the texts. The current app is written with Kotlin. Could you also have a look at kotlin\PlanesAndroid\app\src\main\res in order to proof-read the other texts ? I have already taken your corrections from the Java app to the Kotlin app.

IunaIuna commented 1 year ago

Hey, yes, I can do that. Sorry, I was on a short vacation trip.

Will take a look and give you feedback

Am Sa., 8. Okt. 2022 um 08:56 Uhr schrieb Cristian Cucu < @.***>:

I have merged the pull request. You have corrected the texts in the Java Android App.

These are only some of the texts. The current app is written with Kotlin. Could you also have a look at kotlin\PlanesAndroid\app\src\main\res in order to proof-read the other texts ? I have already taken your corrections from the Java app to the Kotlin app.

— Reply to this email directly, view it on GitHub https://github.com/xxxcucus/planes/issues/20#issuecomment-1272247306, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH6ABUHB7O6DRPFL4KT666TWCELILANCNFSM6AAAAAAQCSYEMM . You are receiving this because you were assigned.Message ID: @.***>