search

xyNNN / GoogleTagManagerBundle

Google Tag Manager Bundle for Symfony 2
https://github.com/xyNNN/GoogleTagManagerBundle
GNU Lesser General Public License v3.0
27 stars 15 forks source link

Support Symfony 6 #46

Closed hcerveragarc closed 1 year ago

hcerveragarc commented 2 years ago

Hello there,

I was wondering if it would be possible to check that dependencies symfony/* version 6 are compatible with this package and, if so, upgrade the composer to allow them.

At least with symfony/dependency-injection, it doesn't seem that any breaking change has been added - https://github.com/symfony/dependency-injection/releases/tag/v6.0.0

Thanks already for your project.

xyNNN commented 2 years ago

Currently I'm busy and not able to answer your question. Perhaps you can fork this repository and try out if this package works smooth with the all components of the newest major release? Feel free to create a pull request! Thanks!

hcerveragarc commented 2 years ago

Thanks for your answer. We are currently upgrading a project to Symfony 6 and your package is a mandatory dependency. I will create a fork next time I have this project in my hands.

dsbe-ak commented 1 year ago

I've created a pull request #47

hcerveragarc commented 1 year ago

@dsbe-ak Thanks :)

xyNNN commented 1 year ago

See https://github.com/xyNNN/GoogleTagManagerBundle/releases/tag/4.0.0