search

xyproto / zsnes

A maintained fork of ZSNES, a Super Nintendo emulator. The original project needs patches to build and is not maintained anymore: https://sourceforge.net/projects/zsnes/
https://zsnes.com
GNU General Public License v2.0
131 stars 16 forks source link

Add support for 8MB SA-1/SDD-1 roms #17

Closed TrashRaccoonSnuffy closed 1 year ago

TrashRaccoonSnuffy commented 1 year ago

Currently, 8MB roms that utilize SA-1 or SDD-1 are not recognized by ZSNES and cannot be opened. There was a fork of the program that added support for these roms here https://fusoya.eludevisibility.org/emulator/zsnes8.html (source code linked on page as well) and if possible, the changes from it should be ported to here.

I could look into porting this feature to the repository, but I am unable to compile it on Ubuntu 20.04, so perhaps instructions should be added for it?

xyproto commented 1 year ago

Thanks for the feature request! I want to incorporate these improvements. But, looking at the fusoya web site, I could not see if the SA-1 changes are copyrighted or free to use and distribute. Furthermore, the author does not want to answer questions about this per e-mail:

However, if for some reason you're just really determined to contact me anyway [...] and don't have an inquiry about source code or porting something I've worked on [...] ONLY then may you try emailing me

https://fusoya.eludevisibility.org/contact.html

Can you see if there is any license info, and/or e-mail the author and ask if the changes can be used here?

TrashRaccoonSnuffy commented 1 year ago

Thank you for the response. I sent an email and will share the answer here soon, however analyzing the source code of the program, it appears that the same GPL2 license is included in the modified files, with comments containing "Fusoya:" marking the modifications.

TrashRaccoonSnuffy commented 1 year ago

image Response, I guess we're good to go in that case^^

xyproto commented 1 year ago

Thanks for e-mailing and posting the reply.

I removed the e-mail address from my comment (even though I believe the spam bots are smart enough to add or remove words, and soon smart enough to follow any "unecryption" instructions tan average human could follow).

I guess finding out which changes should be made is the next step, and then testing if it works.

TrashRaccoonSnuffy commented 1 year ago

Solved with https://github.com/xyproto/zsnes/pull/23 , a solution will have to be found to not require 16MB maxromspace, but it shouldn't really affect anyone besides needing 10~ extra MB of RAM to run ZSNES. Fixing this just involves moving off the special end of ROM variables out of the rom buffer. I have no idea why it's designed this way, but it's an easy fix.