search

xzzz9097 / Muse

An open-source Spotify controller with TouchBar support
635 stars 41 forks source link

The album cover doesn't get loaded when using Muse i.c.w. Apple Music #10

Open wuotr opened 7 years ago

wuotr commented 7 years ago

First of all... I love this nifty little app. Thank you for building it ;-).

But the album cover doesn't get loaded when using Muse i.c.w. Apple Music... The standard green-orange placeholder is shown instead: screen shot 2017-07-14 at 11 31 07 This is the case for both the onscreen window as with the TouchBar itself.

xzzz9097 commented 7 years ago

Thank you! Unfortunately I can't test Apple Music as I don't have an account for it. Could you run this code in AppleScript editor and paste the response here? With a local track it returns the PNG or JPEG data, I'm wondering if it provides an URL like Spotify with remote songs.

tell application "iTunes"
data of artwork[1] of current track
end tell
wuotr commented 7 years ago

Indeed that's the issue. When playing Apple Music songs I added to the Library everything works fine. But when streaming from the "New" or "For You" section the current track is actually a URL track. Although this instance inherits from track, the artwork element list is not exposed through iTunes scriptability so no cover art is available. => https://stackoverflow.com/questions/37455735/how-to-access-apple-music-album-art-in-itunes-via-apple-script

The output of your small script gives:

error "iTunes got an error: Parameter error." number -50
xzzz9097 commented 7 years ago

So, 057d0f13b6d88886713d7f490d833c5392ab4994 is an attempt to fix this by fetching artwork from Spotify servers, a bit rough and not tested much though. I'm a bit busy this weekend, I will check this again next week.

xzzz9097 commented 7 years ago

I've pushed the necessary commits to master branch. I've tested by manually returning nil in iTunes artwork fetching, thus triggering download from Spotify servers, and it seemed to work pretty well. Here's a test build if you want to try it.

wuotr commented 7 years ago

Hi @xzzz9097,

Cool! Thanks for pursuing on fixing this. I just downloaded your test build en it seems to work pretty well indeed 😉. #kudos

hburrichter commented 6 years ago

Hi @xzzz9097, is this workaround still in your app? Tried the 4.0 alpha and the last stable release but I don't see an album artwork if I stream from apple music. If I add the playlist/album/song to my library and play it from there everything works fine.

That being said, thanks for the awesome app!