search

yacineMTB / talk

Let's make sand talk
587 stars 43 forks source link

Audio process stops after a few minutes #38

Closed choombaa closed 1 year ago

choombaa commented 1 year ago

After ~4 minutes, the audio process (record_audio.sh) stops sending chunks.

For some reason, adding a listener on stderr fixes the issue:

audioProcess.stderr.on('data', (data) => {
  console.log(data);
});

Not sure why this works, but the application works fine for 45+ minutes with this snippet.

yacineMTB commented 1 year ago

hmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmm wtf?

jmanhype commented 1 year ago

I can concur

yacineMTB commented 1 year ago

Oh of course the stream gets filled up because we're not consuming the events, it basically just like fills up otherwise, rec would basically leak (keep on taking more RAM over time) so it blocks to stop this from happening i will patch cheers lads

yacineMTB commented 1 year ago

https://github.com/yacineMTB/talk/commit/e81b8a6c02e67b4cad4c8a5326296cb713025d07

choombaa commented 1 year ago

Omg this was actually the fix