yadm-dev / yadm

Yet Another Dotfiles Manager
https://yadm.io/
GNU General Public License v3.0
5.15k stars 176 forks source link

Fix Makefile portability #390

Closed signed-log closed 3 years ago

signed-log commented 3 years ago

What does this PR do?

Permits a portable install without breaking $(PREFIX) (and the software altogether)

Previous Behavior

With the old version, that wasn't possible, as it would try to install the software in the worker folder, of course something denied on public instances (like OBS).

New Behavior

Adding $(DESTDIR) before all paths ensure that you can install to another folder, old behaviour is restored if the variable is not declared as it is assumed empty by make

Have tests been written for this change?

No

Have these commits been signed with GnuPG?

Yes


Please review yadm's Contributing Guide for best practices.