yakivmospan / github-wikito-converter

Generate HTML & PDF documentation from Github wiki or any other markdown-based wiki.
Other
293 stars 52 forks source link

Fix bug with filenames that contain dots #15

Closed JamesCullum closed 6 years ago

JamesCullum commented 6 years ago

Filenames that contain dots (for example 1.1-test.md) were successfully inventoried in the TOC, but the files weren't added to the documentation. This was due to the different mechanisms of generating IDs - the alias is extracted from the filename, while this helper function also filters out values, including dots. If the values don't match, the file is not added to the output.

If there are similiar bugs in the future, this should be the point to look at.

yakivmospan commented 6 years ago

Thanks for your contribution, will publish new version with it on the board, soon.

yakivmospan commented 6 years ago

https://github.com/yakivmospan/github-wikito-converter/releases/tag/1.4.0

JamesCullum commented 6 years ago

Cheers 👍