yakivmospan / github-wikito-converter

Generate HTML & PDF documentation from Github wiki or any other markdown-based wiki.
Other
293 stars 52 forks source link

Shortcut Image Links not Hooked Up #29

Open yakivmospan opened 6 years ago

yakivmospan commented 6 years ago

As MarikaGrzebieniowska mention, GitHub's[[assets/image.png]] shortcut style is not working, while ![](assets/image.png) is doing well.

Yingmin-Li commented 6 years ago

shortcut style is not working, while does not work neither.

yakivmospan commented 6 years ago

@Yingmin-Li send us sample project, where "while" is not working for you.

denisalevi commented 4 years ago

Hi @yakivmospan. Thanks for the great work, gwtc has been very handy.

I would love to see [[assets/image.png]] type links working with gwtc. From what I saw in the html output, the [[assets/image.png|This is an image]] type links were translated into [This is an image](assets/image.png). Would adding an ! in front of the link solve the issue? Possibly here?

And GitHub also allows [[assets/image.png|width=200px]] type links which I use a lot. Having them working would be fantastic. As far as I can tell, the GitHub links are translated to HTML img tags, like this: <img src="assets/imags.png">. Which happens here? In principle it should be possible to add the width or height styles to the img tag: <img src="assets/imags.png" width="200">. But as far as I understand, currently the GitHub wiki [[...]] links are first translated to markdown links []() and for the markdown links I don't think there is a syntax to specify width and height. So maybe this would need more than adding a ! to get this working...

What do you think?

yakivmospan commented 4 years ago

Hey Denis,

from a quick google, I do see it is possible to add a size to markdown syntax. But unfortunately, right now I have no free time to dig into it and develop an update here.

Still, all sorts of Pull Requests are welcomed here. You can try it on your local machine, if it will work for you, don't be shy to share it here :)