Refactor Logic for Permission Request Status

yalelibrary / YUL-DC

Preliminary issue tracking for Yale University Libraries Digital Collections project

3 stars 0 forks source link

Refactor Logic for Permission Request Status #2791

Closed laurenb33 closed 1 month ago

laurenb33 commented 3 months ago

Permission Request Status is currently using Boolean values. To better suit OwP, we would like to change the options of true/false to approved, denied, and pending. Default as "Pending."

Acceptance

[x] change the options of true/false to approved, denied, pending, and expired.

jpengst commented 2 months ago

Management PR: https://github.com/yalelibrary/yul-dc-management/pull/1367
Blacklight PR: https://github.com/yalelibrary/yul-dc-blacklight/pull/1002

jpengst commented 1 month ago

Deployed to Demo v2.68.6 and Blacklight OwP_FeatureBranch

sshetenhelm commented 1 month ago

Approved, denied, and pending work. Gave myself permission for an object for only today; will verify tomorrow if "Expired" status works as well for objects moving forward.

Past expirations still have the "approved" status (although that's not an issue if it works moving forward).

sshetenhelm commented 1 month ago

Lauren made ticket #2819 for the Expired status, so I think this is ready to close.