Speedup crafiting calculation

yamamushi / dumap

A guide for Dual Universe

17 stars 15 forks source link

Speedup crafiting calculation #113

Open Macroft opened 4 years ago

Macroft commented 4 years ago

Eliminate need for simulation by tallying ingredients as a pool. Prevents slowdown seen when several items were added to the crafting queue.

using objects as maps to avoid search loops

Fixes #112

Allen-Tainia commented 4 years ago

I really like the speed increase but there's something wrong going on with the final amount. for example, craft 1 warp drive:

the amount of sulfur pure need is -7 (time is negative too)
not all ores seem to be a multiple of 65 (or 585 for t1 batches). same kind of issue for the pures
no catalyst given (catalyst is needed)

@Macroft I would like to chat with you when you get some free time because i'm looking at reworking parts here and there to make the calculator easier to follow and for some very needed updates at this point. Message me via discord when you can (Velenka)

Macroft commented 4 years ago

Made some tweaks, think everything is adding up correctly now. it would be nice if others checked with recipes they are familiar with.

MasteredRed commented 3 years ago

Aware that I'm not completely up to speed on the repo, but I saw this pull request and am confused. Is there a reason this hasn't been denied or accepted already?

yamamushi commented 3 years ago

@Macroft do you still need this merged? I don't know why I never got a notification for it :(

Macroft commented 3 years ago

I have been distracted by other parts of life. If it still merges cleanly I can tell you it drastically improves performance. But I may not be super responsive to bug fixing.

On Wed, Jul 21, 2021, 10:36 Will Navidson @.***> wrote:

@Macroft https://github.com/Macroft do you still need this merged? I don't know why I never got a notification for it :(

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/yamamushi/dumap/pull/113#issuecomment-884329159, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF3JQX7QW6QYBGBQJ5OJ6DTY3ZPJANCNFSM4SUIAZFA .

yamamushi commented 3 years ago

Any ideas how to resolve this merge conflict?

Macroft commented 3 years ago

I will take a look at it tomorrow and let you know

On Wed, Jul 21, 2021, 12:00 Will Navidson @.***> wrote:

Any ideas how to resolve this merge conflict?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/yamamushi/dumap/pull/113#issuecomment-884381504, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF3JQQOJQYZ3YW7BVV2ZKLTY4DKLANCNFSM4SUIAZFA .