Test suite is giving [ OK ] even when no references or wrong references exist

[sangallidavide]

Something is not working properly in the test-suite.

---

• Example 1 I edited the input file 15_td_sex inside Si_bulk/RT

  git diff TESTS/MAIN/Si_bulk/RT/INPUTS/15_td_sex
  diff --git a/TESTS/MAIN/Si_bulk/RT/INPUTS/15_td_sex b/TESTS/MAIN/Si_bulk/RT/INPUTS/15_td_sex
  index ad9e4fd1..70797c15 100644
  --- a/TESTS/MAIN/Si_bulk/RT/INPUTS/15_td_sex
  +++ b/TESTS/MAIN/Si_bulk/RT/INPUTS/15_td_sex
  @@ -40,7 +40,7 @@ CORRLvcs= 59         RL    # [XX] Exchange RL components
  # RT Parameters
  #
  Integrator= "RK2 RWA"    # [RT] Integrator ( "RK2 / EULER" "EXP" "RWA" )
  -NETime= 150.00000       fs   # [RT] Simulation Time (alternative to NEsteps)
  +NETime= 50.00000       fs   # [RT] Simulation Time (alternative to NEsteps)
  RTstep=   20           as    # [RT] Real Time step length
  #LifeInterpKIND= "NONE"               # [RT] Step distribution mode
  #% LifeInterpSteps

  The output of nohup ./driver.pl -tests Si_bulk/RT -keys rt -branch develop & is

  
  tail -f LOG-R2-develop-precompiled-MPI+OpenMP+SLEPC+HDF5_MPI_IO-gfortran-SERIAL.log
  [serial] 15_coll_sex:  static screening collisions     3.2s
  o-15_coll_sex.ndb.COLLISIONS_HXC_fragment_2     [  OK  ]
  o-15_coll_sex.ndb.em1s_fragment_1               [  OK  ]
  [serial] 15_td_sex:  NEGF                              1.9s
  o-15_td_sex.carriers                            [  OK  ]
  o-15_td_sex.current                             [  OK  ]
  o-15_td_sex.energy                              [  OK  ]
  o-15_td_sex.external_field                      [  OK  ]
  o-15_td_sex.polarization                        [  OK  ]
  o-15_td_sex.thermodynamics                      [  OK  ]

vimdiff  15_td_sex/o-15_td_sex.carriers REFERENCE/o-15_td_sex.carriers
gives the output below
![image](https://user-images.githubusercontent.com/22720887/110860426-0b015a80-82bd-11eb-8a9a-58bc10d56739.png)

____________________________________
* Example 2
I've created a new input in my local version, folder hBN/RT.
Test called `11_td_sex_dbgd_Gless`
No REFERENCE file created and this is the output

[serial] 11_td_sex_dbgd: NEGF 4.1s o-11_td_sex_dbgd.carriers [ OK ] o-11_td_sex_dbgd.current [ OK ] o-11_td_sex_dbgd.energy [ WHITELISTED ] o-11_td_sex_dbgd.external_field [ OK ] o-11_td_sex_dbgd.polarization [ OK ] o-11_td_sex_dbgd.thermodynamics [ WHITELISTED ] [serial] 11_td_sex_dbgd_Gless: NEGF 12.0s o-11_td_sex_dbgd_Gless.carriers [ OK ] o-11_td_sex_dbgd_Gless.current [ OK ] o-11_td_sex_dbgd_Gless.external_field [ OK ] o-11_td_sex_dbgd_Gless.polarization [ OK ]

while

ls TESTS/MAIN/hBN/RT/REFERENCE/11_td_sex_dbgd_Gless ls: cannot access 'TESTS/MAIN/hBN/RT/REFERENCE/11_td_sex_dbgd_Gless': No such file or directory

[sangallidavide]

Even if I kill yambo_rt simulations of the test-suite while they are running test-suite gives [OK] to final output

[sangallidavide]

Source of this issue is the following coding in find_the_diff script

 !
 N_data_to_check=min(ref%N,out%N)
 !
 call eval_the_moments(ref,N_data_to_check)
 call eval_the_moments(out,N_data_to_check)

without any check on the difference (ref%N-out%N)

[sangallidavide]

Fixed with commit d0df8c6