search

yanchenglee98 / pe

0 stars 0 forks source link

Unclear error message for edit-attraction when out of bounds #2

Open yanchenglee98 opened 3 years ago

yanchenglee98 commented 3 years ago

When a index that exceeds the number of attractions is provided to edit-attraction, it says "At least one field to edit must be provided" which is confusing to the user as it implies that 20 is a valid index

image.png

Would be good to be similar to delete-attraction and state that index is invalid

image.png

nus-se-bot commented 3 years ago

Team's Response

Our app first checks if the given command is valid, ie whether it has the correct fields, before checking if the index is valid. Thus, the app will show the error message that at least one field need to be inputted, before it will reach the error message that the index is invalid. "Delete-attraction 20" is a valid command input, so it will show that index is invalid, instead of saying that the command is invalid.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]