search

yanchenglee98 / pe

0 stars 0 forks source link

find-itinerary will parse invalid dates #5

Open yanchenglee98 opened 3 years ago

yanchenglee98 commented 3 years ago

find-itinerary parses invalid dates such as find-itinerary 35-09-2020. Would be good to inform user that date is invalid instead of just displaying an empty list

image.png

nus-se-bot commented 3 years ago

Team's Response

Find keyword works for any string and finds any field, and is not restricted to any formatting. Find command does not work with prefixes. But even so, there is no date prefix infront of the keyword, so the string is not considered an invalid date. In this case, an itinerary could be called 35-09-2020, and the find keyword is searching for it, so it is not an invalid keyword.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]